-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommonHTML fixes for digits, Jeem, and Haa #16
CommonHTML fixes for digits, Jeem, and Haa #16
Conversation
@OmarIthawi This PR is ready for your review :) |
@shadinaif Please bump up the version (like we did in bc9ff76) to I think all of the changes look good, but I need to double check on the Test Case 6 updates shortly. |
Version bump is done @OmarIthawi . Regarding Test Case 6, this is the fixing code 8704990#diff-0f0b9bfbcff9748d4ec0e7b8ebd1ebe0R43 |
…c in this version
Thanks @shadinaif, I've copied it to a new issue (#17). Will take a look soon. |
@OmarIthawi Thank you for opening the new issue #17 . Indeed, the I believe the PR is ready now for your final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In CommonHTML enviroment: this is to fix the render for some scripts related to numbers and letters with (tatweel جـ هـ):
Test case 1
fix position for
\frac
operator\frac{1}{2}+\frac{A}{B}+\frac{C}{E}
before:
after:
Test case 2
fix over-line position for numbers
\overline{A}\space\overline{B}\space\overline{0}\space\overline{1}\space\overline{2}
before:
after:
Test case 3:
fix over-line position for Jeem and Haa
\overline{A}\overline{B}\overline{C}\overline{D}\overline{E}\overline{F}
before:
after:
Test case 4:
fix bar position for Jeem and Haa
\bar{A}\bar{B}\bar{C}\bar{D}\bar{E}\bar{F}
before:
after:
Test case 5:
fix numbers position inside square root. Applied on Jeem and Haa too
\sqrt{12345678c}
before:
after:
Test Case 6 has been removed because it is not valid in Arabic. Users must use
\transn
to represent decimals. That will convert the dot to the Arabic decimal comma separatorExample:
\transn{1.234}\\\overline{\transn{1.234}}
Test case 6:fix text alignment for decimal numbers when used with \\1.234\\\overline{1.234}
before:Fixes #10